ext/soap: fix NULL deref on empty Body with SOAPAction (RPC) - #161
Closed
iliaal wants to merge 1 commit into
Closed
Conversation
iliaal
force-pushed
the
soap-ss007-empty-body-soapaction
branch
from
July 16, 2026 00:51
4d2dbdb to
298fdb8
Compare
iliaal
force-pushed
the
soap-ss007-empty-body-soapaction
branch
from
July 16, 2026 11:26
298fdb8 to
563dc2a
Compare
When SoapServer resolves the operation via the SOAPAction header and the SOAP Body has no element child, func remains NULL. The RPC branch then did func = func->children and crashed. Guard the children walk so empty-body requests with a matching SOAPAction are handled safely.
iliaal
force-pushed
the
soap-ss007-empty-body-soapaction
branch
from
July 16, 2026 11:29
563dc2a to
88834fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When SoapServer resolves the operation via the SOAPAction header and the SOAP Body has no element child,
funcremains NULL. The RPC path then didfunc = func->childrenand crashed.Guard the children walk so empty-body requests with a matching SOAPAction are handled safely.